On Thu, Jun 2, 2011 at 4:40 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>> + case I8042_COMMAND_REG: {
>> + u8 value = kbd_read_status();
>> + ioport__write8(data, value);
>> + break;
>> + }
>> + case I8042_DATA_REG: {
>> + u32 value = kbd_read_data();
>> + ioport__write32(data, value);
>> + break;
>> }
>> + default:
>> + break;
>
> should we BUG_ON() [or WARN_ON()] in that 'default' case?
>
>> + default:
>> + break;
>
> ditto. This could have caught the bug straight away, right?
I changed them to return false. That WARN_ON should be in common code, I think.
Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
