Re: [PATCH] kvm: Fix build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/31/2011 10:38 AM, Ingo Molnar wrote:
* Borislav Petkov<bp@xxxxxxxxx>  wrote:

>  +++ b/arch/x86/kvm/paging_tmpl.h
>  @@ -121,7 +121,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>   				gva_t addr, u32 access)
>   {
>   	pt_element_t pte;
>  -	pt_element_t __user *ptep_user;
>  +	pt_element_t __user *uninitialized_var(ptep_user);

Note that doing this is actually actively dangerous for two reasons.



<snip lots of good advice>

Please fix it instead.

s/instead/in addition/; while all those changes are good, they are much too large for 3.0. Let's push the simple fix for 3.0 and queue the bigger refactoring to 3.1.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux