On 2011-05-29 18:19, Avi Kivity wrote:
> On 05/27/2011 03:19 PM, Jan Kiszka wrote:
>> Activate the iothread version of qemu_cpu_kick. We just need to
>> initialize the yet unused CPUState::halt_cond for it.
>>
>> This finally obsoletes kvm_update_interrupt_request, so drop it.
>>
>
> void qemu_cpu_kick(void *_env)
> {
> CPUState *env = _env;
>
> qemu_cond_broadcast(env->halt_cond);
> if (!env->thread_kicked) {
> qemu_cpu_kick_thread(env);
> env->thread_kicked = true;
> }
> }
>
> Seems to have redundancies - we're both signalling a condition variable
> and sending a signal.
>
The target may block on the halt condition or run in guest mode. I don't
think we can (and should) try to find out which wakeup call is sufficient.
Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
