Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Avi Kivity <avi@xxxxxxxxxx> wrote:

> Yes, this is equivalent to the kernel's stop_machine_run().  It's a 
> heavyweight method but it should work just fine.

Yeah. It is fine for reconfiguration/configuration-only kind of write 
paths - i.e. the mmio lookup path should be ok.

There's only one thing i'd like to warn about: please still shape it 
as a br_read_lock()/unlock(), br_write_lock()/unlock() operation.

This way all the SMP read paths remain identified properly, even if 
br_write_lock() does a stop_machine_run() equivalent. This still 
leaves options open for an easy conversion to rwlock or urcu (should 
any particular write path become more than just occasional).

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux