* Pekka Enberg <penberg@xxxxxxxxxx> wrote: > Hi Ingo, > > On Fri, May 27, 2011 at 1:54 PM, Ingo Molnar <mingo@xxxxxxx> wrote: > > A sidenote: i think 'struct kvm *kvm' was a naming mistake - it's way > > too aspecific, it tells us nothing. What is a 'kvm'? > > Why, an instance of a kernel virtual machine, of course! It was the > very first thing I wrote for this project! Oh, that is way too funny: i never thought of 'KVM' as a 'kernel virtual machine' :-/ It's the name of a cool kernel subsystem - not the name of one instance of a virtual machine. > On Fri, May 27, 2011 at 1:54 PM, Ingo Molnar <mingo@xxxxxxx> wrote: > > A much better name would be 'struct machine *machine', hm? Even if > > everyone agrees this would be a separate patch, obviously. > > Well, I don't really think 'struct machine' is that much better. The > obvious benefits of 'struct kvm' is that it's the same name that's > used by Qemu and libkvm and maps nicely to '/dev/kvm'. To me /dev/kvm is what interfaces to 'KVM' - where 'KVM' is the magic, axiomatic name for the aforementioned cool kernel subsystem! :-) > If you really, really wanna change it, I could use some more > convincing or bribes of some sort. No, i guess the naming is just fine, i just need to rewire 5 years worth of neural pathways ;-) I'll save the bribes for a worthier goal! :-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
