On Thu, May 26, 2011 at 09:49:21AM +0200, Paolo Bonzini wrote: > On 05/26/2011 09:07 AM, Gleb Natapov wrote: > >> Still, op_bytes is irrelevant for > >> SrcDX, the 16-bit version is always used. > > > >If SrcDX/DstDX will be used only for decoding in/out instruction > >then yes. Otherwise it is nice to have more general decoder. > > Not counting instructions that read/write many registers > (rdmsr/wrmsr, mul/imul/div/idiv, rdtsc, etc.), I think the only > other instruction with an implicit DstDX is cwd/cdq/cqo. Since > cwd/cdq/cqo needs c->dst.bytes = c->src.bytes (not op_bytes) I think > DstDX is not really reusable beyond port instructions. > Why would c->dst.bytes != c->src.bytes for cwd/cdq/cqo if we'll set c->dst.bytes to op_bytes during decode? -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
