Hi, On Fri, May 20, 2011, Tian, Kevin wrote about "RE: [PATCH 07/31] nVMX: Introduce vmcs02: VMCS used to run L2": > Possibly we can maintain the vmcs02 pool along with L1 VMCLEAR ops, which > is similar to the hardware behavior regarding to cleared and launched state. If you set VMCS02_POOL_SIZE to a large size, and L1, like typical hypervisors, only keeps around a few VMCSs (and VMCLEARs the ones it will not use again), then we'll only have a few vmcs02: handle_vmclear() removes from the pool the vmcs02 that L1 explicitly told us it won't need again. > > +struct saved_vmcs { > > + struct vmcs *vmcs; > > + int cpu; > > + int launched; > > +}; > > "saved" looks a bit misleading here. It's simply a list of all active vmcs02 tracked > by kvm, isn't it? I have rewritten this part of the code, based on Avi's and Marcelo's requests, and the new name for this structure is "loaded_vmcs", i.e., a structure describing where a VMCS was loaded. > > +/* Used to remember the last vmcs02 used for some recently used vmcs12s > > */ > > +struct vmcs02_list { > > + struct list_head list; > > + gpa_t vmcs12_addr; > > uniform the name 'vmptr' as nested_vmx strucure: Ok. Changing all the mentions of "vmcs12_addr" to vmptr. -- Nadav Har'El | Sunday, May 22 2011, 18 Iyyar 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |"A witty saying proves nothing." -- http://nadav.harel.org.il |Voltaire -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html