Re: [PATCH] kvm tools, 9p: Test for tuncation result

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2011-05-21 at 16:35 +0300, Pekka Enberg wrote:
> On Sat, May 21, 2011 at 3:10 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> > Without 'ret' usage I get
> >
> >  | cyrill@sun kvm $ make
> >  |  CC       virtio/9p.o
> >  | virtio/9p.c: In function ʽvirtio_p9_wstatʼ:
> >  | virtio/9p.c:448:6: error: variable ʽresʼ set but not used [-Werror=unused-but-set-variable]
> >  | cc1: all warnings being treated as errors
> >  | make: *** [virtio/9p.o] Error 1
> >
> > so add a basic check for ftruncate result, this eliminate warning and
> > we might need to use 'res' status later in caller code.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> > CC: Sasha Levin <levinsasha928@xxxxxxxxx>
> 
> Sasha?

Looks good to me.

Acked-by: Sasha Levin <levinsasha928@xxxxxxxxx>

> > ---
> >
> > Pekka, are you fine with 'kvm-tools,9p' prefix?
> 
> Sure.

-- 

Sasha.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux