On Wed, May 18, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > Note this is not just about the code being nicer, but simplicity is > crucial, the code is tricky enough with one linked list. Unfortunately, it's not obvious that the method you suggested (and which, like I said, was the first method I considered as well, and rejected) will be simpler or less tricky, with its two "cpu" variables, vmcs pointing to l1_vmcs even in the non-nested case, and a bunch of other issues. The main benefit of the code as I already posted it was that it didn't add *any* complexity or changed anything to the non-nested case. The code I'm writing now based on your suggestions is more risky in the sense that it *may* break some things completely unrelated to nested. In any case, like I said, I'm working on a version using your and Avi's suggestions, and will send it for your review shortly. Thanks for all the ideas, Nadav. -- Nadav Har'El | Wednesday, May 18 2011, 14 Iyyar 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Sign seen in restaurant: We Reserve The http://nadav.harel.org.il |Right To Serve Refuse To Anyone! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html