* Prasad Joshi <prasadjoshi124@xxxxxxxxx> wrote:
> @@ -583,6 +585,11 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix)
> exit_code = 1;
> }
>
> + for (i = 0; i < MAX_DISK_IMAGES; i++) {
> + if (image_disks[i])
> + disk_image__close(image_disks[i]);
> + }
Isnt this a method that the disk/image subsystem wants to provide? Or at least
it should move into an inline - kvm_cmd_run() is *way* too big already at 200
lines and these patches are how it grows!
it should split into several helpers, setting up various aspects of the
context, then one separate helper doing the vcpu startup and waiting.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
