Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/18/2011 08:52 AM, Nadav Har'El wrote:
On Tue, May 17, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling":
>  On Tue, May 17, 2011 at 10:30:30PM +0300, Nadav Har'El wrote:
>  >  So we'll have two fields, vmx.vcpu.cpu and vmx.vmcs.cpu, which are supposed
>  >  to always contain the same value. Are you fine with that?
>
>  Yes. Avi?

Oops, it's even worse than I said, because if the new vmclear_local_vmcss
clears the vmcs currently used on some vcpu, it will update vmcs.cpu on that
vcpu to -1, but will *not* update vmx.vcpu.cpu, which remain its old value,
and potentially cause problems when it is used (e.g., in x86.c) instead
of vmx.vmcs.cpu.


I did a quick audit and it seems fine. If it isn't, we'll fix it when we see the problem.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux