On Tue, May 17, 2011 at 05:35:32PM +0300, Nadav Har'El wrote: > On Tue, May 17, 2011, Avi Kivity wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > static DEFINE_PER_CPU(struct list_head, vmcss_on_cpu); > > This is an interesting suggestion. My initial plan was to do something similar > to this, and I agree it could have been nicer code, but I had to change it > after bumping into too many obstacles. > > For example, currently, vmclear_local_vcpus() not only VMCLEARs the vmcss, > it also sets vmx->vcpu.cpu = -1, xmv->launched=0 for the vcpus holding these > VMCSs. If we had only a list of VMCSs, how can we mark the vcpus as being not > currently loaded (cpu=-1)? Do it in vcpu_clear, its just an optimization not necessary in vmclear_local_vcpus path. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html