On Mon, May 16, 2011, Nadav Har'El wrote about "Re: [PATCH 12/30] nVMX: Implement VMPTRLD": > But now that I think about it, there does appear to be a problem in > nested_vmx_run(): This is where we should have verified that there is a > current VMCS - i.e., that VMPTRLD was previously used! And it seems I forgot > testing this... :( I'll need to add such a test - not as a BUG_ON but as > a real test that causes the VMLAUNCH instruction to fail (I have to look at > the spec to see exactly how) if VMPTRLD hadn't been previously done. Oh, and there appears to be a similar problem with VMWRITE/VMREAD - it also can be called before VMPTRLD was ever called, and cause us to dereference stupid pointers. Thanks for spotting this. Nadav. -- Nadav Har'El | Monday, May 16 2011, 13 Iyyar 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |If I were two-faced, would I be wearing http://nadav.harel.org.il |this one?.... Abraham Lincoln -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
