Re: [PATCH 1/2] kvm tools: Bring VIRTIO_BLK_F_SEG_MAX feature back to virtio blk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/13/2011 10:07 PM, Sasha Levin wrote:
> On Fri, 2011-05-13 at 15:46 +0300, Pekka Enberg wrote:
>> On 5/13/11 5:40 AM, Asias He wrote:
>>> commit b764422bb0b46b00b896f6d4538ac3d3dde9e56b
>>> (kvm tools: Add support for multiple virtio-blk)
>>> removed the VIRTIO_BLK_F_SEG_MAX publishment to guest.
>>>
>>> There is no reason we should not support it. Just bring it back.
>>>
>>> Signed-off-by: Asias He<asias.hejun@xxxxxxxxx>
>>
>> Sasha?
> 
> I'm not sure why it was removed, must have missed it when updating
> struct blk_dev.
> 
> On the other hand, why do we need to limit max segment size?

That's because the number of entries in a scatter-gather operation must
be less than the entries in the virt queue we can offer.


-- 
Best Regards,
Asias He
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux