On Fri, May 13, 2011 at 10:43:33AM +0200, Markus Armbruster wrote: > Glauber Costa <glommer@xxxxxxxxxx> writes: > > > This patch adds a dummy legacy ISA device whose responsibility is to > > deploy sgabios, an option rom for a serial graphics adapter. > > The proposal is that this device is always-on when -nographics, > > but can otherwise be enable in any setup when -device sga is used. > > > > [v2: suggestions on qdev by Markus ] > > One more question: should "-device sga" suppress the default VGA? The > other three VGA devices do; check out default_list[] in vl.c. No, it should not. This rom is specially designed not to: It will chain all int10h requests to whatever it was there before. > > [...] > > diff --git a/hw/pc.h b/hw/pc.h > > index 1291e2d..a00e054 100644 > > --- a/hw/pc.h > > +++ b/hw/pc.h > > @@ -219,6 +219,9 @@ int isa_vga_mm_init(target_phys_addr_t vram_base, > > void pci_cirrus_vga_init(PCIBus *bus); > > void isa_cirrus_vga_init(void); > > > > +/* serial graphics */ > > +void isa_sga_init(void); > > + > > No longer exists, please drop. You're right, my bad. Anthony, is it needed to send a v3 to take this away, or will you remove manually ? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html