* Asias He <asias.hejun@xxxxxxxxx> wrote: > On 05/12/2011 02:01 AM, Pekka Enberg wrote: > > This patch changes the '-c' command line option to specify the number of CPUs > > because it's used more often than console switching. > > I'd like to tune the command line option further. > > 1) > Change > -i, --image <image> Disk image > to > -d, --disk <disk> Disk image Agreed. > 2) > Change > -r, --initrd <initrd> > Initial RAM disk image > to > -i, --initrd <initrd> > Initial RAM disk image Agreed. > 3) > Change > -d, --kvm-dev <kvm-dev> > KVM device file > -s, --single-step Enable single stepping > -g, --ioport-debug Enable ioport debugging > to > --kvm-dev <kvm-dev> > KVM device file > --single-step Enable single stepping > --ioport-debug Enable ioport debugging Yeah, it would be nice to free up -d, -s, -g. The debug options should probably be concentrated under a --debug option anyway, to allow things like: --debug single-step,ioport Even if the debug options are kept they should be streamlined along the same pattern: > --debug-single-step Enable single stepping > --debug-ioport Enable ioport debugging But having a --debug option that recognizes all the debug flags would be nicer. It would also allow future enhancements to group debug features, like: --debug all # turn on everything and the kitchen sink for early hangs --debug all,-single-step # turn on everything except single-step debugging --debug nonverbose # turn on all non-noisy debug options we have Maybe even: --debug memcheck ... could run kvm under valgrind automatically - that way we can hide any secondary tool complexities from the user and turn those tools into simple debug options :-) etc. > So we can have > -c --cpus > -m --mem > -d --disk > -k --kernel > -i --initrd > which is more consistent and easy to remember. Very nice plans! The sooner we do this the fewer people will have to change their scripts and practices. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html