On Wed, May 11, 2011 at 12:05 AM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote: > queue->pfn may be used to point at addresses larger > than 32 bit. > Prevent a wraparound when shifting it left. > > Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx> > --- > tools/kvm/virtio/blk.c | 2 +- > tools/kvm/virtio/console.c | 2 +- > tools/kvm/virtio/net.c | 2 +- > tools/kvm/virtio/rng.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/kvm/virtio/blk.c b/tools/kvm/virtio/blk.c > index 12c7029..b7fea79 100644 > --- a/tools/kvm/virtio/blk.c > +++ b/tools/kvm/virtio/blk.c > @@ -197,7 +197,7 @@ static bool virtio_blk_pci_io_out(struct kvm *self, u16 port, void *data, int si > > queue = &bdev->vqs[bdev->queue_selector]; > queue->pfn = ioport__read32(data); > - p = guest_flat_to_host(self, queue->pfn << 12); > + p = guest_flat_to_host(self, (u64)queue->pfn << 12); Lets make a guest_pfn_to_host() helper for this instead. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
