Re: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Subject: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique v2

PCI device numbers must be unique on a bus (as a part
of Bus/Device/Function tuple).Make it so. Note the patch
is rather a fast fix since we need a bit more smart pci device
manager (in particular multiple virtio block devices most
probably should lay on a separate pci bus).

v2: Sasha spotted the nit in virtio_rng__init, ioport
   function was touched insted of irq__register_device.

Hey, I don't like the new patch subject trend you're trying to start at all. You can make it

  kvm tools,pci: Make PCI device numbers unique

but in this particular case "PCI" already appears in the title so

  kmv tools: Make PCI device numbers unique

is the right thing to do.

In addition, the changelog doesn't really tell me much. Does it fix something? Why would we need a "smart pci device manager" and why is that relevant for this patch? Hmmh?

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux