On Mon, May 09, 2011, Avi Kivity wrote about "Re: [PATCH 15/30] nVMX: Move host-state field setup to a function": > > static int vmx_vcpu_setup(struct vcpu_vmx *vmx) > > { > >- u32 host_sysenter_cs, msr_low, msr_high; > >- u32 junk; > >+ u32 msr_low, msr_high; > > > Unused? Well, it's actually is used, because I left the GUEST_IA32_PAT setting in vmx_vcpu_setup. I guess I couldn't have moved these two variables inside the if((vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PAT) block, but I didn't. Similarly, the host_pat variable can also move inside the if(). I'll make these changes. -- Nadav Har'El | Monday, May 9 2011, 5 Iyyar 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Shortening Year-2000 to Y2K was just the http://nadav.harel.org.il |kind of thinking that caused that problem! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html