Re: [PATCH 1/2] kvm tools: Respect ISR status in virtio header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2011-05-07 at 16:47 +0200, Ingo Molnar wrote:
> Can you anything in the virtio protocol implementation that would explain 
> networking lags, which seem to be caused by guest notifications either not be 
> sent or being missed?
> 
> In particular this sequence:
> 
> > while pending_requests:
> >    a = get_next_request();
> >    process_next_request(a);
> 
> is apparently not what Qemu uses - so maybe there's some latent bug or some 
> silly oversight somewhere.
> 
> It is suboptimal and i agree with you that the better sequence should be 
> implemented, but the above *should* work, yet it does not.

Yes, so the performance benefits of Asias' patch aren't the interesting
part but the fact that it fixes a real bug in our tool.

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux