On 05/05/2011 11:06 PM, Cyrill Gorcunov wrote:
> It's better than have them sprinkled in.c files. Note
> that pin for ring device is changed so it no longer shared
> with block device (it is done in a sake of simplicity).
>
> Also comment style if a bit tuned up in virtio-pci.h
> just to be consistent.
>
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> ---
...
> +
> +enum {
> + VIRTIO_BLK_PIN = 1,
> + VIRTIO_CONSOLE_PIN = 2,
> + VIRTIO_NET_PIN = 3,
> + VIRTIO_RNG_PIN = 4,
> +};
> +
Btw, probably the better way would be to make it like that
enum {
PCI_INTA = 1,
PCI_INTB = 2,
PCI_INTC = 3,
PCI_INTD = 4,
};
enum {
VIRTIO_BLK_PIN = PCI_INTA,
VIRTIO_CONSOLE_PIN = PCI_INTB,
VIRTIO_NET_PIN = PCI_INTC,
VIRTIO_RNG_PIN = PCI_INTD,
};
So we would know the connection way and pin shares if needed.
--
Thanks,
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
