On 2011-05-05 10:22, Avi Kivity wrote: > On 05/04/2011 10:43 PM, Jan Kiszka wrote: >> All required bits for this cleanup of qemu-kvm are now upstream and >> merged back - it's time to start the show. There are now 65 patches in >> my queue, and I'm planning for at least 4 rounds. >> >> This first part primarily aims at using upstream kvm_arch_init. Further >> highlights are: >> - switch to upstream CPU register get/put >> - switch to upstream kvmclock >> - sustainable breakage of IA64 >> >> Please review/merge. >> > > I didn't do a line-by-line review, just a general look around, and it > all looks good except for the MSR behavioural change. > > How did you test it? Running various VMs, mostly Linux (including vmmouse support) but also some XP guests. I'm using the whole series for internal purposes for a few months now (frequently rebased). So I have a quite good feeling about it, except for the unknown corner cases. :) > I suggest testing at least vmport in addition to > an autotest run (if you don't have a setup ready, we can do it, but it > would be really helpful to test pre-merge). I guess we can expect a few > regressions but if we're too careful this mess will continue forever. I would be happy to off-load the full autotest run to $someone_else. Will jump in again if it fails. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html