On 05/04/2011 06:44 PM, Sasha Levin wrote:
...
>>
>> There should really be a helper function for these initializations - and a loop
>> that creates VIRTIO_BLK_MAX_DEV of them, right?
>>
>> Also, the IRQs used by kvm should be enumerated in an include file in a single
>> place, with ranges allocated for specific purposes, otherwise we'll quickly
>> lose track of them.
>>
>
> The plan is that mptable.c is going to change either way, Cyrill noted
> we need a way to manage IRQs earlier in that file. That's also why I
> tried not changing it too much.
>
...
Sasha, I simply out of time, sorry guys. So if you can -- move irqs into
separate file and make loop for block devices this would be great I guess.
We need a global collector/manager for pins/irqs so caller would do something
like
irq_alloc(struct irq_cfg *req)
where
struct irq_cfg {
int flags;
int vector;
int pin;
}
or something like that. I don't have a clear picture yet.
Ingo, on the other hands, maybe open-coded snippets would be fine for
a while?
--
Thanks,
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
