Re: [PATCH 6/6] KVM: PPC: Add kvm headers to headers_install

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03.05.2011, at 17:10, Jan Kiszka wrote:

> On 2011-05-03 17:04, Alexander Graf wrote:
>> 
>> On 03.05.2011, at 16:44, Jan Kiszka wrote:
>> 
>>> On 2011-05-03 16:36, Alexander Graf wrote:
>>>> 
>>>> On 03.05.2011, at 16:20, Jan Kiszka wrote:
>>>> 
>>>>> On 2011-05-03 14:37, Alexander Graf wrote:
>>>>>> When running "make headers_install", we don't install kvm headers on
>>>>>> PPC. This confuses Qemu, as it really wants to include kernel headers
>>>>>> to know the ioctl structs.
>>>>>> 
>>>>>> So let's add the arch/powerpc/include/asm headers that are important
>>>>>> for KVM to the headers_install list.
>>>>>> 
>>>>>> Signed-off-by: Alexander Graf <agraf@xxxxxxx>
>>>>>> ---
>>>>>> arch/powerpc/include/asm/Kbuild |    2 ++
>>>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>>> 
>>>>>> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
>>>>>> index d51df17..568b000 100644
>>>>>> --- a/arch/powerpc/include/asm/Kbuild
>>>>>> +++ b/arch/powerpc/include/asm/Kbuild
>>>>>> @@ -34,3 +34,5 @@ header-y += termios.h
>>>>>> header-y += types.h
>>>>>> header-y += ucontext.h
>>>>>> header-y += unistd.h
>>>>>> +header-y += kvm.h
>>>>>> +header-y += kvm_para.h
>>>>> 
>>>>> Weird, just worked for me with current kvm master without your patch.
>>>> 
>>>> Oh? You did do make headers_install and it did push the correct headers to usr?
>>> 
>>> I strongly suspect. It's all documented in my header patch.
>> 
>> Your header patch manually copies the respective files, so you're not using that code path there?
>> 
> 
> I'm copying from the output dir auf headers_install (INSTALL_HDR_PATH).
> What step does this patch target at?

Ah, there it is. I find makefiles very hard to read :). No idea why it worked for you. I can certainly run make headers_install on a ppc machine later today and see if it magically started working on current master. :)


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux