Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/18/2011 04:56 PM, Isaku Yamahata wrote:
This patch would fix the segfaults. But I suppose the followings
are necessary.

- PIIX4PMState::gpe_cpu needs to be saved/loaded somewhere

Yes.  Juan?

- gpe_writeb() needs to handle PROC_BASE ... PROC_BASE+31
   like gpe_readb(). To be honest, I don't see why gpe_readb/writeb()
   are used for PROC_BASE...PROC_BASE + 31


Even before the merge, we didn't handle a write to this address. Perhaps it's read-only? (that should explain no save/restore).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux