* Pekka Enberg <penberg@xxxxxxxxxx> wrote: > On Sat, 16 Apr 2011, Ingo Molnar wrote: > > > > >* Pekka Enberg <penberg@xxxxxxxxxx> wrote: > > > >>On Fri, Apr 15, 2011 at 10:43 PM, Prasad Joshi <prasadjoshi124@xxxxxxxxx> wrote: > >>>Include the Linux kernel header file linux/stringify.h file instead of > >>>redefining the __stringify* macros > >>> > >>>Signed-off-by: Prasad Joshi <prasadjoshi124@xxxxxxxxx> > >>>--- > >>> tools/kvm/include/kvm/util.h | 5 ++--- > >>> 1 files changed, 2 insertions(+), 3 deletions(-) > >>> > >>>diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/util.h > >>>index ae033cc..c308f3f 100644 > >>>--- a/tools/kvm/include/kvm/util.h > >>>+++ b/tools/kvm/include/kvm/util.h > >>>@@ -1,3 +1,5 @@ > >>>+#include "../../../../include/linux/stringify.h" > >> > >>#include <linux/stringify.h> should just work, no? > > > >Only if kernel headers are installed. Also, and perhaps more importantly, in > >the context of perf it was more robust to use the same kernel repo's source > >code that perf resides in - should there be any fixes needed it's a lot easier > >to remedy things. > > We do this in the Makefile: > > -I../../include -I../../arch/$(ARCH)/include/ > > so it should just work. Oh, nice! :-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
