Re: [PATCH] kvm tools: Fix 64-bit assumptions and type uglinesses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 9 Apr 2011, Ingo Molnar wrote:
Make the MIN_RAM_SIZE_MB constant 64-bit on 32-bit systems as well, otherwise
we get this build failure:

 kvm-run.c: In function âkvm_cmd_runâ:
 kvm-run.c:119: error: format â%luâ expects type âlong unsigned intâ, but argument 2 has type âu64â

Also adjust affected printf format string - this necessiates the use of
the sane Linux definition of u64 instead of the brain-dead int64_t
variant.

That also allows (and necessiates) the removal of the ugly PRIu64 format
string hackery. Friends don't let friends use PRI* hackeries! :-)

Yeah, we definitely should do a tree-wide sweep of s/uint64_t/u64/, etc., and PRI* removal.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

Applied, thanks!

			Pekka

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux