Re: [PATCH 3/3] kvm tools: add virtio console support v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Asias,

On 4/8/11 5:05 AM, Asias He wrote:
- Consolidate all console related code to term.c
- Use timer based approach instead of thread to deal with user input
- Introduce --enable-virtio-console option, this option disables
   serial console output

NOTE:
Please add something like this:
T2:23:respawn:/sbin/getty -L hvc0 9600 vt100
to your /etc/inittab file to get a virtio console login.

Signed-off-by: Asias He<asias.hejun@xxxxxxxxx>
---
  tools/kvm/8250-serial.c                |   40 +-----
  tools/kvm/Makefile                     |    2 +
  tools/kvm/console-virtio.c             |  218 ++++++++++++++++++++++++++++++++
  tools/kvm/include/kvm/8250-serial.h    |    2 +-
  tools/kvm/include/kvm/console-virtio.h |    9 ++
  tools/kvm/include/kvm/term.h           |   17 +++
  tools/kvm/main.c                       |   48 ++-----
  tools/kvm/term.c                       |   89 +++++++++++++

Is it too much trouble to ask you to split this patch into two: (1) the term.c refactoring and (2) virtio console implementation? That would make the series much easier to review.

                Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux