On Mon, 04 Apr 2011 08:09:29 -0500 Anthony Liguori <anthony@xxxxxxxxxxxxx> wrote: > On 04/04/2011 07:19 AM, Markus Armbruster wrote: > > [Note cc: Anthony] > > > > "Daniel P. Berrange"<berrange@xxxxxxxxxx> writes: > > > >> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: > >>> From: Lai Jiangshan<laijs@xxxxxxxxxxxxxx> > >>> Date: Mon, 7 Mar 2011 17:05:15 +0800 > >>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command > >>> > >>> inject-nmi command injects an NMI on all CPUs of guest. > >>> It is only supported for x86 guest currently, it will > >>> returns "Unsupported" error for non-x86 guest. > >>> > >>> --- > >>> hmp-commands.hx | 2 +- > >>> monitor.c | 18 +++++++++++++++++- > >>> qmp-commands.hx | 29 +++++++++++++++++++++++++++++ > >>> 3 files changed, 47 insertions(+), 2 deletions(-) > >> Does anyone have any feedback on this addition, or are all new > >> QMP patch proposals blocked pending Anthony's QAPI work ? > > That would be bad. Anthony, what's holding this back? > > It doesn't pass checkpath.pl. > > But I'd also expect this to come through Luiz's QMP tree. I had this ready in my tree some time ago, but you commented on that version asking for errors descriptions and other things, so I didn't push it. But we have to set expectations here. My tree will eventually die, specially wrt new interfaces where I expect you to jump in ASAP. First because you have to be sure a new interface "conforms" to QAPI, and second (and more importantly) because it's time to pass this on to someone else (preferably you). -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
