On 04/03/2011 07:09 PM, Takuya Yoshikawa wrote:
> > IMHO, we are using dst operand for too many things. > > > > In the case of CMP, I first tried to use src2 to clearly follow the > > SDM's "second source operand" terminology. But it seemed not worth > > it now. > > > > Ah, CMP is encoded as dst/src, so it's best to just disable writeback > there. We could have a bit in the decode tables to auto-disable > writeback, but not sure it is worth it. One more question: Why some functions in this file are defined using "static inline" not just "static" ? I should keep these "inline" ?
Just 'static' is enough, the compiler can usually make the best decision wrt. inline.
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
