On Mon, Mar 28, 2011 at 08:28:12AM -0400, Avi Kivity wrote: > The spec indicates we need to check the TSS and IOPL based permissions > before the intercept (vmx agrees). With the code as is, it happens > afterwards. > > One way to do this is to have an ExtraChecks bit in the opcode::flags. > Then opcode::u.xcheck->perms() is the pre-intercept check and > opcode::u.xcheck->execute() is the post-intercept execution. Should > work for monitor/mwait/rdtsc(p)/rdpmc/other crap x86 throws at us. Okay, as you suggested, I put these checks into the instruction emulator and let the hard work of implementing per-arch checks to the nested-vmx people ;) I doubt that this makes the opcode-tables more readable, but lets see :) Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
