On 03/29/2011 03:12 PM, Marcelo Tosatti wrote:
On Thu, Mar 24, 2011 at 05:35:27PM +0200, Avi Kivity wrote: > On 03/24/2011 05:19 PM, Gleb Natapov wrote: > >> Two patches one to revert REQ_NMI then another to fix the original problem > >> makes backporting easier. > >If we agree this is the way to go will do that. > > > > Not sure, want to think about it for a bit. Ping?
I think Gleb's approach is better. ->requests is fine for notifications but not for state.
I'd like to see ACCESS_ONCE() semantics for the vcpu variable, so we don't introduce races, even if they are benign. A problem with benign races is that you have to re-think about them later to be sure they are still benign.
We also need to document which vcpu variables are asynchronous. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
