On Wed, Mar 9, 2011 at 1:21 PM, Corentin Chary <corentin.chary@xxxxxxxxx> wrote: > The threaded VNC servers messed up with QEMU fd handlers without > any kind of locking, and that can cause some nasty race conditions. > > The IO-Thread provides appropriate locking primitives to avoid that. > This patch makes CONFIG_VNC_THREAD depends on CONFIG_IO_THREAD, > and add lock and unlock calls around the two faulty calls. > > Thanks to Jan Kiszka for helping me solve this issue. > > Cc: Jan Kiszka <jan.kiszka@xxxxxx> > Signed-off-by: Corentin Chary <corentin.chary@xxxxxxxxx> > --- > The previous patch was total crap, introduced race conditions, > and probably crashs on client disconnections. Forget that one too, also deadlock on vnc_jobs_join(). I'll need some more time to fix that. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
