On 03/07/2011 05:06 AM, Xiao Guangrong wrote:
We can get the large mapping pte in the loop: static bool shadow_walk_okay(struct kvm_shadow_walk_iterator *iterator) { if (iterator->level< PT_PAGE_TABLE_LEVEL) return false; if (iterator->level == PT_PAGE_TABLE_LEVEL)
if (is_large_pte(*iterator->sptep)) return false; ...... } if level> 1 and pte.pse is set, it will return true. And, i think this judgment is useless: if (iterator->level == PT_PAGE_TABLE_LEVEL) if (is_large_pte(*iterator->sptep)) return false; since if level = 1, the pte bit7 is PAT.
Right, the logic is inverted. I'll fix it up. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html