Re: [PATCH 2/3] kvm-unit-tests: do not set level sensitive irq when initializing the PIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/24/2011 11:48 PM, Anthony Liguori wrote:
I'm not sure if this was intentional but the QEMU i8259 does not support this
flag.  I haven't observed any issues with this but I'll happily admit that
I'm not very aware of what I'm doing here.

Signed-off-by: Anthony Liguori<aliguori@xxxxxxxxxx>

  static u32 xapic_read(unsigned reg)
  {
      return *(volatile u32 *)(g_apic + reg);
@@ -133,7 +129,7 @@ void ioapic_write_redir(unsigned line, ioapic_redir_entry_t e)
  void enable_apic(void)
  {
      printf("enabling apic\n");
-    xapic_write(0xf0, 0x1ff); /* spurious vector register */
+    xapic_write(0xf0, 0x1f7); /* spurious vector register */
  }

Not sure what you're doing here. You're changing the APIC Spurious Vector from 0xff to 0xf7? This has nothing to do with the i8259 or level triggeredness as far as I can tell - it just enables the APIC (bit 8) and selects a vector for reporting spurious interrupts (0xff happens to be the reset value).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux