On Thu, 2011-02-24 at 14:34 +0200, Avi Kivity wrote: > On 02/23/2011 11:46 PM, Alex Williamson wrote: > > > > > > But kvm_arch_flush_shadow() takes mmu_lock currently, so that needs > > > fixing. > > > > Hmm, I tried to follow the example in the !npages path just above this > > that does: > > > > rcu_assign_pointer() > > synchronize_srcu_expedited() > > kvm_arch_flush_shadow() > > > > Do we have an existing issue there with mmu_lock? Thanks, > > > > It's the issue I pointed out - after rcu_assign_pointer and before > kvm_arch_flush_shadow() we can still get shadow pages created, so we > have a mix of direct and indirect bitmap. Either my solution (recording > whether the bitmap is direct or not in kvm_mmu_page) or Marcelo's > (preventing shadow instantiation during this period) should work. Thanks, I understand better now. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
