On Fri, Feb 18, 2011 at 04:15:38PM +0800, Sheng Yang wrote: > > Why allow this ioctl to succeed if there's an entry already present? > > This case is broken as mmio_dev->mmio_nr is increased below. > > Oh, It's a bug to let mmio_nr increase even with MMIO found. I've fixed it. > > The reason we allow multiply callings is userspace can register different types of > address here(table address and PBA address). Ah OK. > > PCI bits must be reviewed... > > Pardon? PCI related things are already in 2.6.38-rc. I meant someone more familiar with PCI should review this patch, Michael/Alex, CC'ed. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html