Re: [PATCH] Remove ethtool from rtl8139 variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 18, 2011 at 05:14:09PM -0200, Lucas Meneghel Rodrigues wrote:
> As the original patch set don't define supported_features
> for it.
> 
> Signed-off-by: Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx>

Acked-by: Amos Kong <akong@xxxxxxxxxx>

> ---
>  client/tests/kvm/tests/ethtool.py      |    6 +++++-
>  client/tests/kvm/tests_base.cfg.sample |    1 +
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm/tests/ethtool.py b/client/tests/kvm/tests/ethtool.py
> index 81e45d3..d7c6b57 100644
> --- a/client/tests/kvm/tests/ethtool.py
> +++ b/client/tests/kvm/tests/ethtool.py
> @@ -191,7 +191,11 @@ def run_ethtool(test, params, env):
>      filename = "/tmp/ethtool.dd"
>      guest_ip = vm.get_address()
>      ethname = kvm_test_utils.get_linux_ifname(session, vm.get_mac_address(0))
> -    supported_features = params.get("supported_features").split()
> +    supported_features = params.get("supported_features")
> +    if supported_features:
> +        supported_features = supported_features.split()
> +    else:
> +        supported_features = []
>      test_matrix = {
>          # type:(callback,    (dependence), (exclude)
>          "tx":  (tx_callback, (), ()),
> diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
> index 7eb3635..816a94f 100644
> --- a/client/tests/kvm/tests_base.cfg.sample
> +++ b/client/tests/kvm/tests_base.cfg.sample
> @@ -903,6 +903,7 @@ variants:
>  variants:
>      - @rtl8139:
>          nic_model = rtl8139
> +        no ethtool
>          jumbo:
>              mtu = 1500
>      - e1000:
> -- 
> 1.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux