On 15.02.2011, at 00:49, Scott Wood wrote: > On Tue, 15 Feb 2011 00:39:51 +0100 > Alexander Graf <agraf@xxxxxxx> wrote: > >> On 14.02.2011, at 22:16, Scott Wood wrote: >> >>> On Mon, 14 Feb 2011 21:19:19 +0100 >>> Alexander Graf <agraf@xxxxxxx> wrote: >>>>>> The struct name should also have >>>>>> a version indicator - it's the data descriptor only a single specific >>>>>> mmu_type, right? >>>>> >>>>> It handles both KVM_MMU_PPC_BOOK3E_NOHV and KVM_MMU_PPC_BOOK3E_HV. >>>> >>>> Even fictional future changes to the tlb layout? >>> >>> No, those need a new MMU type ID. >> >> ... which means they need a new name, but then booke_tlb_entry is taken. > > The MMU ID name and struct name are about equally generic. I'll add FSL to > both. If there's a v2 down the road, then that goes in both. Very good - thank you! Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html