Am 14.02.2011 17:48, schrieb Eric Dumazet: > Le lundi 14 fÃvrier 2011 Ã 17:37 +0100, Patrick McHardy a Ãcrit : >> Am 14.02.2011 17:29, schrieb Eric Dumazet: >>> Le lundi 14 fÃvrier 2011 Ã 17:24 +0100, Patrick McHardy a Ãcrit : >>>>> Also, I wonder if RCU rules are respected in nf_iterate(). >>>>> For example this line is really suspicious : >>>>> >>>>> *i = (*i)->prev; >>>> >>>> Yeah, that definitely looks wrong. How about this instead? >>>> >>> >>> This patch seems fine to me, thanks ! >>> >>> Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx> >> >> THanks Eric, I've queued the patch for 2.6.38. > > I am not sure, but I guess nf_reinject() needs a fix too ;) I agree. That one looks uglier though, I guess we'll have to iterate through all hooks to note the previous one. I'll take care of that once Dave has pulled the last fix since I already sent out the pull request. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
