On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote: > > Do you really find it easier to read evaluations grouped with || ? I > > don't. > > I do, specifically as the old version was even more confusing in that > important detail "return 0" vs. "return 1". But even the new benefits > from the grouping IMHO. Well alright. > > Sorry but the name change does not feel right either: CPU is still idle > > if the vm is not running. > > But that's exactly what the function returns. Or is it confusing if we > are talking about the vcpu or the whole thread here? What about > "cpu_thread_is_idle" then? Yes thats better. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html