On Tue, Feb 08, 2011, Avi Kivity wrote about "Re: [PATCH 15/27] nVMX: Prepare vmcs02 from vmcs01 and vmcs12": > >So isn't the first setting, in vmx_vcpu_setup(), redundant? > > It is. It's just historical baggage - these lines were introduced about > 20 commits into kvm development (af9d6e204919016ca in qemu-kvm.git) and > never removed, even after it was fixed to be per-cpu. Thanks. As part of my patch, I'm splitting off a function vmx_set_constant_host_state() from vmx_vcpu_setup() (the same function will also be used to set up the host state on vmcs02). So I'll remove that redundant setting from this function. -- Nadav Har'El | Tuesday, Feb 8 2011, 4 Adar I 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Quotation, n.: The act of repeating http://nadav.harel.org.il |erroneously the words of another. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
