[PATCH] x86: Fix MCA broadcast parameters for TCG case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-02-02 20:05, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@xxxxxxxxx>
> ---
>  target-i386/helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 1217452..4bbf9b1 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> bank, uint64_t status,
>                      continue;
>                  }
> 
> -                qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> +                qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
>              }
>          }
>      }

Let's fix this for real, the value is wrong anyway:

----------8<----------

From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>

When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
it is done for KVM. Use the symbolic constants at this chance.

Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
---
 target-i386/helper.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-i386/helper.c b/target-i386/helper.c
index d74b6e3..f41416f 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1145,8 +1145,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
                 if (cenv == env) {
                     continue;
                 }
-
-                qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+                qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC,
+                                    MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0);
             }
         }
     }
-- 
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux