On Fri, 28 Jan 2011 01:57:11 +0100 Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: > I personally would consider it cleaner to have clearly > defined wrappers instead of complicted flags in the caller. > > > The number of args to these functions is getting nutty - you'll > > probably find that it is beneficial to inline these wrapepr functions, if > > the number of callsites is small. > > Really the functions are so heavy weight it should not matter. > The problem with inlining is that you end up with the code in > the header file and I personally find that much harder to browse > instead of having everything in one file. You'll cope. > Also longer term we'll get compilers that can do cross-file inlining > for optimized builds. Which we'll probably need to turn off all over the place :( > So please better avoid these kinds of micro optimizations unless > it's a really really extremly speed critical path. It's not just speed and it's not just .text size, either. Calling a ten-arg function consumes stack space. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
