On Wed, Jan 12, 2011, Xiao Guangrong wrote about "[PATCH v3 2/3] KVM: send IPI to vcpu only when it's in guest mode": > We can interrupt the vcpu only when it's running in guest mode > to reduce IPI Hi, I am afraid there's a risk of confusion between the new vcpu->mode = IN_GUEST_MODE; and the existing is_guest_mode() (i.e., vcpu->arch.hflags & HF_GUEST_MASK) The latter says that the virtual cpu is in guest mode (i.e., the guest used VMLAUNCH and is runnning a nested guest), while the former says that the physical CPU that this vcpu is currently being run on, is in guest mode - or in other words, this vcpu is currently running. I'm not sure what is the best way to resolve this potential for confusion. Maybe on of them is better renamed (e.g., instead of vcpu->mode = IN_GUEST_MODE have something like vcpu->running = NOW_RUNNING). Or maybe some good comments need to to be written to explain the situation. Actually, I just noticed that there's already a vcpu->guest_mode which you are apparently replacing, so the potential for confusion is already in the current code... I.e., in the current code, is_guest_mode(vcpu) does NOT check vcpu->guest_mode... -- Nadav Har'El | Wednesday, Jan 12 2011, 7 Shevat 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Hi! I'm a signature virus! Copy me into http://nadav.harel.org.il |your signature to help me spread! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
