Am 11.01.2011 00:02, Anthony Liguori wrote: > On 01/10/2011 04:21 PM, Jan Kiszka wrote: >> Am 10.01.2011 22:06, Jan Kiszka wrote: >> >>>> kvmclock should be created with >>>> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >>>> reference. Taking a global reference to kvm_state in machine_init is >>>> not a bad thing, obviously the machine initialization function needs >>>> access to the kvm_state. >>>> >>> This would also require changing sysbus interfaces for the sake of KVM's >>> "abstraction". If this is the only way forward, I could look into this. >>> >> Actually, there is already a channel to pass pointers to qdev devices: >> the pointer property hack. I'm not sure we should contribute to its user >> base or take the chance for a cleanup, but we are not alone with this >> requirement. Point below remains valid, though. >> > > It probably makes sense to have a KVMBus and not pass it as a property > but rather have it access it from the KvmBusState. KVM is orthogonal to the qtree. Some devices like vga (kvm_coalesce_*, kvm_log_start/stop*) would actually have to be attached to multiple buses in this model. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
