Re: [Autotest] [PATCH] KVM test: Fix typos in ethtool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 07, 2011 at 01:21:09PM -0200, Lucas Meneghel Rodrigues wrote:
> Signed-off-by: Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx>
> ---
>  client/tests/kvm/tests/ethtool.py |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/client/tests/kvm/tests/ethtool.py b/client/tests/kvm/tests/ethtool.py
> index 011df29..9708497 100644
> --- a/client/tests/kvm/tests/ethtool.py
> +++ b/client/tests/kvm/tests/ethtool.py
> @@ -104,11 +104,11 @@ def run_ethtool(test, params, env):
>          if src == "guest":
>              session.cmd_output(dd_cmd, timeout=360)
>              tcpdump_cmd += " and src %s" % guest_ip
> -            copy_files_fun = vm.copy_files_from
> +            copy_files_from = vm.copy_files_from
>          else:
>              s, o = commands.getstatusoutput(dd_cmd)
>              tcpdump_cmd += " and dst %s" % guest_ip
> -            copy_files_fun = vm.copy_files_to
> +            copy_files_from = vm.copy_files_to
>          if s != 0:
>              return (False, "Fail to create file by dd, cmd: %s" % dd_cmd)
>  
> @@ -125,7 +125,7 @@ def run_ethtool(test, params, env):
>  
>          logging.info("Start to transfer file")
>          try:
> -            copy_files_fun(filename, filename):
> +            copy_files_from(filename, filename)

Does this patch base on a wrong fix ?
there is no 'copy_files_fun(filename, filename):' in original ethtool.py
Current ethtool.py also exists an typo, will send a patch to fix this.

>          except kvm_utils.SCPError, e:
>              return (False, "File transfer failed (%s)" % e)
>          logging.info("Transfer file completed")
> -- 
> 1.7.3.4
> 
> _______________________________________________
> Autotest mailing list
> Autotest@xxxxxxxxxxxxxxx
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux