Re: [PATCH] pci-assign: Fix transition MSI->INTx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-01-06 at 15:40 +0200, Avi Kivity wrote:
> On 01/04/2011 11:04 PM, Jan Kiszka wrote:
> > From: Jan Kiszka<jan.kiszka@xxxxxxxxxxx>
> >
> > Make sure to re-register the IRQ of an assigned device as INTx when the
> > guest disables MSI[X] mode again.
> >
> > Signed-off-by: Jan Kiszka<jan.kiszka@xxxxxxxxxxx>
> 
> Cc: More Reviewers

Looks fine to me.

Acked-by: Alex Williamson <alex.williamson@xxxxxxxxxx>

> > ---
> >   hw/device-assignment.c |    6 ++++++
> >   1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> > index f6410f8..fce7567 100644
> > --- a/hw/device-assignment.c
> > +++ b/hw/device-assignment.c
> > @@ -1192,7 +1192,10 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
> >           if (kvm_assign_irq(kvm_context,&assigned_irq_data)<  0)
> >               perror("assigned_dev_enable_msi: assign irq");
> >
> > +        assigned_dev->girq = -1;
> >           assigned_dev->irq_requested_type = assigned_irq_data.flags;
> > +    } else {
> > +        assign_irq(assigned_dev);
> >       }
> >   }
> >   #endif
> > @@ -1332,7 +1335,10 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)
> >               perror("assigned_dev_enable_msix: assign irq");
> >               return;
> >           }
> > +        assigned_dev->girq = -1;
> >           assigned_dev->irq_requested_type = assigned_irq_data.flags;
> > +    } else {
> > +        assign_irq(assigned_dev);
> >       }
> >   }
> >   #endif
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux