On Wed, Dec 29, 2010 at 11:37:58AM +0200, Avi Kivity wrote:
> On 12/22/2010 05:06 PM, Gleb Natapov wrote:
> >Signed-off-by: Gleb Natapov<gleb@xxxxxxxxxx>
> >---
> > lib/x86/processor.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/lib/x86/processor.h b/lib/x86/processor.h
> >index c348808..c3ab109 100644
> >--- a/lib/x86/processor.h
> >+++ b/lib/x86/processor.h
> >@@ -193,13 +193,13 @@ static inline u16 sldt(void)
> >
> > static inline void ltr(unsigned val)
> > {
> >- asm volatile ("ltr %0" : : "rm"(val));
> >+ asm volatile ("ltr %w0" : : "rm"(val));
> > }
>
> Is this really needed? And isn't this done better by declaring 'u16 val'?
>
> >
> > static inline u16 str(void)
> > {
> > u16 val;
> >- asm volatile ("str %0" : "=rm"(val));
> >+ asm volatile ("str %w0" : "=rm"(val));
> > return val;
> > }
> >
>
> This looks completely unneeded, since val is already a u16.
>
IIRC I got errors from assembler. Will recheck.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
