Avi Kivity <avi@xxxxxxxxxx> writes: > On 12/21/2010 05:41 PM, Markus Armbruster wrote: >> Avi Kivity<avi@xxxxxxxxxx> writes: >> >> > On 12/15/2010 07:57 PM, Markus Armbruster wrote: >> >> > In the short term, it would be a good idea to modify qemu-kvm to >> >> > switch the -enable-kvm semantics to match upstream (fail if KVM isn't >> >> > available). >> >> >> >> That's what my patch does. >> >> >> >> Additionally, it changes the default to match upstream: KVM disabled. >> >> >> >> What do you want changed in my patch? >> > >> > The 'Additionally' bit. qemu-kvm users rely on the default enabling >> > kvm. Likely they don't rely on -enable-kvm failing is kvm is not >> > available (and indeed, they likely expect it to match upstream). So >> > the patch should only change behaviour when -enable-kvm is specified. >> >> Like this? >> >> upstream qemu | default |-enable-kvm >> ----------------+-----------+----------- >> KVM available | disabled | enabled >> KVM unavailable | disabled | fail >> >> qemu-kvm | default |-enable-kvm| -no-kvm >> ----------------+-----------+-----------+----------- >> KVM available | enabled* | enabled | disabled >> KVM unavailable | disabled | fail | disabled >> >> * differs from upstream > > Yes. Thanks. I'll cook up a new patch. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
